Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Element.checkVisibility polyfill for Blockly #10241

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Oct 22, 2024

fixes https://github.com/microsoft/pxt-minecraft/issues/2555

this pr adds a simple polyfill for Element.checkVisibility to fix comment rendering in ancient browsers. i wrote the polyfill myself because a cursory search didn't find a suitable one and the method itself is pretty simple. the only thing mine doesn't do is traverse ancestors to check their content-visibility, but that's not needed for the linked bug.

@riknoll riknoll requested a review from a team October 22, 2024 18:31
@riknoll riknoll merged commit c4c2719 into master Oct 22, 2024
6 checks passed
@riknoll riknoll deleted the dev/riknoll/comment-check-visibility branch October 22, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants